Out-of-line prop_conv_solvert::decision_procedure_text to work around g++-5 bug #4723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… g++-5 bug As elaborated in the comment in prop_conv_solver.cpp, under some configurations g++-5 would miscompile the inline version.
smowton
requested review from
kroening,
martin-cs,
peterschrammel and
tautschnig
as code owners
kroening
approved these changes
May 29, 2019
peterschrammel
approved these changes
May 29, 2019
allredj
reviewed
May 30, 2019
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: 6976b67).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/113771892
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As elaborated in the comment in prop_conv_solver.cpp, under some configurations g++-5 would
miscompile the inline version.
This can't be tested without adding yet another CI profile, but anyone with compiler
gcc-5.5.0-12ubuntu1 20171010should be able to reproduce with build-O2 -g0, aka cmake's build typeRelease. In particularobjdump -t cbmcshows a definition fornon-virtual thunk to prop_conv_solvert::decision_procedure_text() constnotnon-virtual thunk to prop_conv_solvert::decision_procedure_text[abi:cxx11]() constas it ought to (and does withg++-7, org++-5 -g).